Re: Bug in svn_wc__entries_write?

Philip Martin <philip@codematters.co.uk> writes:

> /* Close & sync. ### BUG? Why do we sync if the write failed? */
> err2 = svn_wc__close_adm_file (outfile, svn_wc_adm_access_path (adm_access),
> SVN_WC__ADM_ENTRIES, 1, pool);
>
>
> I do not understand why we would want to sync the entries file if the
> write fails, doing so would seem to produce an incomplete, or corrupt,
> entries file. Is this a bug, or am I missing something?

Sure looks like a bug to me. We should call close_adm_file() without
syncing, and if the operation succeeds, use that other wc function to
do the sync manually.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Sep 23 18:06:30 2002