Re: Problem commiting over https

Philip Martin <philip@codematters.co.uk> writes:

> I get the same error over http when I try to commit to a "/" Location.
> Looks like we may have a bug, I seem to remember that "/" didn't work
> at all in the past, and that some recent changes made (some of) it
> work.

From mod_dav_svn/util.c:dav_svn_simple_parse_uri

  len1 = strlen(path);
  len2 = strlen(relative->info->repos->root_path);
  if (len1 < len2
      || (len1 > len2 && path[len2] != '/')
      || memcmp(path, relative->info->repos->root_path, len2) != 0)
    {
      return svn_error_create(SVN_ERR_APMOD_MALFORMED_URI, 0, NULL, pool,
                              "The specified URI does not refer to this "
                              "repository, so it is unusable.");
    }

(gdb) p len1
$9 = 46
(gdb) p len2
$10 = 1
(gdb) p path
$11 = 0x80fd070 "/!svn/act/5ced1e32-edaa-0310-87f1-deb4c70d8c93"
(gdb) p relative->info->repos->root_path
$12 = 0x80cab70 "/"

Anyone know what this code should do? It's failing at the line

      || (len1 > len2 && path[len2] != '/')

since len1 > len2 and path[len2] == '!'.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org