Greg Stein wrote:
> On Tue, Sep 17, 2002 at 09:32:16AM -0400, Garrett Rooney wrote:
>
>>Philip Martin wrote:
>>...
>>
>>>>+
>>>>+ svn_cancel_set_cancel_func (check_cancelled, NULL, svn_pool_create (pool));
>>>>+
>>>>+ signal (SIGINT, cancel);
>>>
>>>APR provides apr_signal in apr_signal.h, should we use that?
>>
>>i'm not sure. signal is theoretically part of the c standard, but for
>>consistency's sake, we should probably use the one from apr. i'll look
>>into it tonight and figure out what to do before committing.
>
>
> "theoretically part of the c standard" just doesn't fly. That's the whole
> reason for APR.
>
> We require ANSI compilers (e.g. gcc), but we don't require ANSI libraries.
> And even if a library is *close* to ANSI, it usually has edge cases that we
> fill in using APR.
sounds like we're using apr_signal then!
;-)
-garrett
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Sep 17 20:18:04 2002