[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] (alternate fix for issue 900)

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2002-09-15 21:15:22 CEST

mark benedetto king <bking@Inquira.Com> writes:

> What I'm getting at is that svn_repos_open can't tell when
> to return that error, either, without peeking inside the
> error in *exactly the same way* that we're describing as
> inappriate for svn_ra_local__split_URL to do.
>
> Am I missing something?

It's not exactly the same, svn_repos_open would not need to follow the
error chain. It could just check err->apr_err, which is how all the
other error checks work. Doing things differently inevitably raises
questions. That doesn't mean your patch is wrong :)

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Sep 15 21:22:33 2002

This is an archived mail posted to the Subversion Dev mailing list.