[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: changing revision props (was: SVN log character encoding.)

From: Karl Fogel <kfogel_at_newton.ch.collab.net>
Date: 2002-09-13 17:10:41 CEST

Greg Stein <gstein@lyra.org> writes:
> However, I *do* worry about enabling that as a remote operation. What hooks
> get run? How is authorization performed? Is logging possible?
>
> Effectively, the operation is lossy -- you lose the previous property value.
> Lossy operations via the network just feels shaky to me. I like the implicit
> requirement that you have shell access (in order to run svnadmin) to change
> any revision properties.

At least for the specific case of the `svn:log-message' revision
property, I think we really need to allow the client to change it.
Fixing up log messages is very common. CVS allows it from the client
side, and people use the functionality. Let's face it, virtually
every SVN site is going to install tweak-log.cgi or something similar,
which effectively means you don't need shell access :-). Since
everyone's going to do it, we might as well make it easy.

Authorization is done as usual for committers.

The new hooks pre_revision_prop and post_revision_prop are run (or
whatever their names are, you get the idea).

I'm not as bothered by a lossy operation being done over the network,
because this particular property value is not reflected in the working
copy anyway.

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Sep 13 17:33:22 2002

This is an archived mail posted to the Subversion Dev mailing list.