[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] svn-config installedness test fails when symlinked

From: Greg Stein <gstein_at_lyra.org>
Date: 2002-09-11 00:31:38 CEST

On Tue, Sep 10, 2002 at 08:00:34PM +0200, Marcus Comstedt wrote:
>
> Karl Fogel <kfogel@newton.ch.collab.net> writes:
>
> > Maybe better to abstract to a function that loopingly resolves
> > symlinks until it reaches the end of the chain? The code above will
> > only resolve one level of symlink.
>
> I'm still hoping for someone to tell me how to get along with the
> Makefile generating thing, so that I can make a proper patch. :-)
> It doesn't really make sense to install a script that tests if it's
> installed. When we're installing it, we _know_ it's going to be
> installed when run from that location, so we should install a script
> that _knows_ that it's installed.

We didn't want to have svn-config generated by ./configure (from the .in
file) and then change it *again* at install time. Thus, we have one script
that just works wherever it sits.

The whole symlink thing can be solved by embedding the target install
directory and just using that. That also solve the problem of people
shifting/copying the file around.

However, I'm not sure how well that plays with DESTDIR. The current code
works great with DESTDIR cuz it only looks at where it sits, rather than
depending upon specific paths...

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Sep 11 00:32:21 2002

This is an archived mail posted to the Subversion Dev mailing list.