[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 3153

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2002-09-10 17:27:46 CEST

Karl Fogel <kfogel@newton.ch.collab.net> writes:

> But there's still a bit of an abstraction failure, in that the code in
> split_url.c "knows" that "" is the empty path, yet path.c wavers
> between using a #define for that and just hardcoding it?
>
> I feel like we could be more clean about this... If "" is the only
> possible empty path, then really, why do we need svn_path_is_empty()
> at all? We could just test path[0] directly every time.

Well, originally I was going to use "." as the empty path, but then I
found that the fs library would need to be changed, and it was simpler
(for me anyway) to change the wc and client libraries to use "". The
path library itself will work with either, hence the local #define. An
explicit "" is used in quite a few places in the code, most of which
used to be "." but I suppose a constant should be used instead.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Sep 10 17:28:24 2002

This is an archived mail posted to the Subversion Dev mailing list.