Re: svn commit: rev 3153

Karl Fogel <kfogel@newton.ch.collab.net> writes:

> Philip, the comments I committed below were written with you in mind.
> Maybe you have thoughts on how to improve the fix of revision 3150.
>
> Didn't we recently have a discussion here about whether
> svn_path_split("/") should return "/" vs ""? If so, did we change its
> behavior to return "/" when given "/" as input? Such a change could
> have caused the bug that rev 3150 fixed, but I'm not sure what the
> best course is, in that case.
>
> Anyway, hoping you have some insight...

Rev 3113 was when I changed the path stuff. As far as I can tell by
looking at the rev 3112 code, I didn't change the behaviour of either
svn_path_split("/"), which always returned "/", or that of
svn_path_is_empty("/"), which always returned FALSE. Thus I think
these bugs may have always been present, but nobody triggered them.

Rev 3138 fixed a similar bug to 3150 (and rev 3113 itself also fixed
one). I identified two suspicious loops around the time rev 3138 was
being discussed, you have now fixed one, the other was in
ok_to_bump_path().

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org