[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] --disable-swig argument for configure

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2002-09-08 00:43:31 CEST

On Saturday, September 7, 2002, at 05:59 PM, Justin Erenkrantz wrote:

> On Sat, Sep 07, 2002 at 04:07:02PM -0400, Garrett Rooney wrote:
>> Here's a patch that implements this option. It seems to work, and I'd
>> commit it now, but I'd like someone with a bit more autoconf knowledge
>> to look over it first and make sure I didn't make any stupid mistakes.
>
> +1. Looks fine.
>
> Only question I have is whether the option should be "--with-swig"
> rather than "--enable-swig" - I've never fully groked the rules on
> this, but my hunch is that it should be AC_ARG_WITH not AC_ARG_ENABLE.
> But, I don't care much either way. -- justin

as much as i hate to admit it (because admitting it means i get to
write more m4, and i hate writing m4), you have a point, AC_ARG_WITH
does sound more appropriate. i'll see what i can do about making it
use that instead.

-garrett

-- 
garrett rooney                    Remember, any design flaw you're
rooneg@electricjellyfish.net      sufficiently snide about becomes
http://electricjellyfish.net/     a feature.       -- Dan Sugalski
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Sep 8 00:44:25 2002

This is an archived mail posted to the Subversion Dev mailing list.