Re: [PATCH] show hook errors on client side

Quoting Karl Fogel <kfogel@newton.ch.collab.net>:

> Philip Martin <philip@codematters.co.uk> writes:
> > The client's post-commit processing depends on the DAV merge-response
> > message returned after a successful commit. If the repos library's
> > svn_repos_fs_commit_txn returns the post-commit hook error then
> > ra_dav's dav_svn_merge will pass that error back to the client instead
> > of the merge-response. Although the client can recognize the error it
> > won't have the merge-response that is required to carry on and do
> > post-commit processing. So, it is not sufficient for the client to
> > recognize a post-commit hook error. We need a something more, either
> > the ability to return an error independently from the merge-response,
> > or the ability to combine the error with the merge-response.
>
> Oh, okay -- I meant "get a non-fatal error along with the merge
> response", not "get a non-fatal error instead of a merge response",
> sorry I didn't make that clearer.
>
> That we must currently choose between the two is a bug.
>
Right, subversion needs to have some mechanism to output warnings basically.
A way for a lib to call back to the client with the warning, and then continue
it's operation.

--
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Kevin Pilch-Bisson
kevin@pilch-bisson.net
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org