[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] show hook errors on client side

From: Karl Fogel <kfogel_at_newton.ch.collab.net>
Date: 2002-09-06 19:20:12 CEST

Philip Martin <philip@codematters.co.uk> writes:
> I tried passing SVN_ERR_REPOS_POST_COMMIT_FAILURE and the error
> passing works. However, that doesn't really solve the problem, if the
> client is going to carry out its post-commit proccessing it needs to
> get the normal successful commit response, with the new revision
> number, etc. Simply having the client recognize a post-commit hook
> error, print it and continue, is not sufficient.

I didn't understand why your last sentence above is true (?).

Granted that non-fatal errors are difficult to implement in the
current scheme of things, but let's assume for the moment that that
bit of architectural lossage were solved: in that case, it should be
sufficient to have the client recognize a post-commit hook error,
print the error as an informational warning, and continue with the
normal post-commit processing. What would be bad about that?

-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Sep 6 19:41:37 2002

This is an archived mail posted to the Subversion Dev mailing list.