[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 3134 - trunk/subversion/libsvn_subr

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2002-09-05 17:12:43 CEST

gstein@tigris.org writes:

> Author: gstein
> Date: 2002-09-04 20:53:01 -0500 (Wed, 04 Sep 2002)
> New Revision: 3134
>
> Modified:
> trunk/subversion/libsvn_subr/path.c
> Log:
> Various little nits while I was perusing this file.
>
> * libsvn_subr/path.c:
> - reorg headers at top of file: ANSI, then APR, then SVN

This order is the reverse of the order I would choose :)

I think header files should be capable of being compiled stand-alone,
without requiring any other headers to be included first. One way to
achieve this is to include in the order application, library, system.
In particular there should be at least one source file that has
svn_path.h as its first include, svn_path.c is the natural choice.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Sep 5 17:13:23 2002

This is an archived mail posted to the Subversion Dev mailing list.