[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 3132 - trunk/subversion/mod_dav_svn

From: Greg Stein <gstein_at_lyra.org>
Date: 2002-09-05 03:27:34 CEST

On Wed, Sep 04, 2002 at 04:15:21PM -0500, philip@tigris.org wrote:
>...
> +++ trunk/subversion/mod_dav_svn/mod_dav_svn.c Wed Sep 4 16:15:21 2002
> @@ -153,7 +153,7 @@
> return "SVNPath cannot be defined at same time as SVNParentPath.";
>
> conf->fs_path
> - = svn_path_canonicalize_nts (apr_pstrdup(cmd->pool, arg1), cmd->pool);
> + = svn_path_canonicalize_nts(apr_pstrdup(cmd->pool, arg1), cmd->pool);

Hmm. Should we strengthen svn_path_canonicalize_nts()'s doc to state that it
will always make a copy of the input path? It already does for most cases,
so it would be nice to do it for the remaining case...

Hrm again. Maybe not... the current definition means that we don't have to
make a copy for already-canonical strings. That is nice from a perf
standpoint.

Okay... never mind the above :-)

Speaking of... since the return value of svn_path_canonicalize_nts() is a
'const char *', there is no reason for the thing to call apr_pmemdup() on
the SVN_EMPTY_PATH. Fixing some of that stuff now...

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Sep 5 03:28:37 2002

This is an archived mail posted to the Subversion Dev mailing list.