Re: [PATCH] show hook errors on client side

Hi Philip!

> > + SVN_ERR (run_hook_cmd ("post-commit", hook, args, FALSE, pool));
>
> Why did you choose to ignore post-commit errors? I suppose it's so
> that the client carries out the post-commit processing and doesn't
> abort. I think it would be better to define a specific error for this

Indeed. It wasn't checking errors before, so I've just used the same
principles.

> case, return that instead of SVN_ERR_REPOS_HOOK_FAILURE, and get the
> client to detect it, print the error message (svn_handle_error with
> FATAL set FALSE probably) and continue.

I must confess I'm not sure how to do that. Is it possible to use
dav_svn_convert_err() in a non-fatal way?

-- 
Gustavo Niemeyer
[ 2AAC 7928 0FBF 0299 5EB5  60E2 2253 B29A 6664 3A0C ]
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org