Re: [TEST PATCH] Minor denial of service attack

Kieran <kieran@esperi.demon.co.uk> writes:

> > $ cd wc
>
> $ touch b

No. I'm setting property 'a' to value 'b' on implicit path '.'

>
> > $ svn ps a b
> > $ svn ci
> > Sending
> >
> > Committed revision 2.

As you see, it worked, I've got a fix :-)

> >
> > See that "Sending" with no path. I think that's a commit feedback
> > bug, and it does makes writing the test difficult
> >

> subversion/libsvn_client/commit.c:670
> svn_error: #21002 : <A general problem occured>
> Commit succeeded, but other errors follow:
>
> subversion/libsvn_client/commit.c:688
> svn_error: #21045 : <Working copy not locked>
> Error bumping revisions post-commit (details follow):
>
> subversion/libsvn_wc/lock.c:280
> svn_error: #21045 : <Working copy not locked>
> directory not locked
> (/usr/local/home/kieran/download/subversion/test-wc/)
>
> I don't know a great deal about properties, but maybe there's a
> problem when the property isn't given a value?

No, it's just a path canonicalisation problem in the new locking code.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org