[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Add support for make install DESTDIR=

From: Jon Middleton <jjm_at_ixtab.org.uk>
Date: 2002-07-30 08:53:49 CEST

On Mon, Jul 29, 2002 at 11:20:39PM -0400, Kevin Pilch-Bisson wrote:
> On Mon, Jul 29, 2002 at 06:21:35PM -0500, Scott Lamb wrote:
> > Jon Middleton wrote:
> > >I'm currently thinking that the changes to axsp2 should be done as an
> > >option to configure (--enable-package-mode or --disable-mod-activate ?)
> > >to allow packagers to disable this activation.
> > >
> > >I'll have a look at doing this change tomorrow night if people think
> > >it's a worthy addition.
> >
> > Yeah, that always bugs me (my httpd.conf loses a tab when it activates
> > the module, so "svn status" shows it as modified after a "make install")
> > but I've never bothered to change it. That's a reason to use it when not
> > packaging, so maybe --disable-mod-activate is better.
>
> You're not the only one who would like to see --disable-mod-activate.
> I'd definitely be in favour of creating that option, and of seeing
> DESTDIR support in gen_base.py. In fact I have almost the exact same
> patch already in my local tree. The only reason I haven't committed
> yet, is that I get errors when installing mod_dav_svn.so, since
> $(DESTDIR)/usr/local/apache2/modules doesn't actually exist, so
> inst_dso.sh can't copy it there. If you have a work around for that
> problem, I'll commit your patch.

It work round this problem by adding a call to

        $(MKDIR) $(DESTDIR)$(APACHE_LIBEXECDIR)

from install-mod-shared so that the directory is created before
calling apxs2. I've attached a patch which only touch's
build/gen_base.py and does remove -a option from apxs2 Makefile.in as
I'm going to start adding

                --enable-mod-activation
                --disale-mod-activation

To configure to night when I get back from work (I think activation is
a beter word to use than activate).

-- 
Jon
"First things first -- but not necessarily in that order"
                -- The Doctor, "Doctor Who"		

  • application/pgp-signature attachment: stored
Received on Tue Jul 30 08:54:28 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.