Re: svn commit: rev 2684

We really have to fix the ra_local__split_url issue on HP-UX ... tests
there have been failing since this commit, and nobody noticed, because
they keep failing anyway :-(

Here's the culprit, in subversion/libsvn_ra_dav/log.c:

+ /* See documentation for `svn_repos_node_t' in svn_repos.h,
+ and `svn_log_message_receiver_t' in svn_types.h, for more
+ about these action codes. */
+ if ((elm->id == ELEM_added_path) || (elm->id == ELEM_replaced_path))
+ {
+ lb->this_path_item->action
+ = (elm->id == ELEM_added_path) ? 'A' : 'R';
+ copyfrom_path = get_attr(atts, "copyfrom-path");
+ copyfrom_rev = get_attr(atts, "copyfrom-rev");
+ if (copyfrom_path
+ && copyfrom_rev
+ && SVN_IS_VALID_REVNUM (copyfrom_rev))
+ {
+ lb->this_path_item->copyfrom_path = apr_pstrdup(lb->subpool,
+ copyfrom_path);
+ lb->this_path_item->copyfrom_rev = atoi(copyfrom_rev);
+ }

And the compiler error:

cc: "../repo/subversion/libsvn_ra_dav/log.c", line 153: error 1649: Illegal integer-pointer combination for >=.
cc: "../repo/subversion/libsvn_ra_dav/log.c", line 151: error 1563: Expression in if must be scalar.

Seems pretty obvious to me, given this definition:

/* Valid revision numbers begin at 0 */
#define SVN_IS_VALID_REVNUM(n) (n >= 0)

A good thing, too, that the HP-UX compiler is so an^H^Hpedantic about
that. :-)

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org