Re: svn commit: rev 2772 - trunk/subversion/libsvn_repos

On Mon, Jul 29, 2002 at 04:18:15PM -0400, William Uther wrote:
>...
> To elaborate a bit, textlen is copied in blocks from the repos. This code
> should work even when the text of the file is too large to fit in an
> apr_size_t. The property code dumps the properties to a string in memory,
> hence apr_size_t is all that is needed.

Right!

> Yes, you could make them all one or the other. If you choose apr_size_t
> then you've lost the ability to handle large files (which may not matter as
> other code already has that limit?).

Theoretically, all file ("text" / "content") lengths should be apr_off_t.
I'm not aware of any cases of using apr_size_t or needing to load the whole
file into memory at one time.

(although I seem to recall Sander saying that "diff" needs to load two or
 three files entirely into memory)

> If you choose apr_off_t then proplen
> is larger than it needs to be, but that's not a major issue.

The proper solution is to introduce svn_filesize_t and use that everywhere.
See issue #639: http://subversion.tigris.org/issues/show_bug.cgi?id=639

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org