[PATCH] Made ac-helpers/find.ap[ru].m4 provide build advice

Tonight I was attempting to build Subversion using "out of tree" apr
and apr-util source trees (freshly pulled from cvs.apache.org to a
location on my file system outside of the SVN sources). Neither of
these APR trees had been built yet, so configure spouted out errors.
After pondering the meaning of the error message for a bit, the
realization that "build directory" needed to be interpreted as "source
directory already built" dawned on me (duh). It would be nice to
provide a little hint for anyone whose neurons habitually misfire like
mine tonight.

-- 
Daniel Rall <dlr@finemaltcoding.com>
Index: ac-helpers/find_apr.m4
===================================================================
--- ac-helpers/find_apr.m4
+++ ac-helpers/find_apr.m4	Fri Jul 26 02:20:36 2002
@@ -65,10 +65,15 @@
     elif $TEST_X "$withval" && $withval --help > /dev/null 2>&1 ; then
       apr_found="yes"
       apr_config="$withval"
+    elif test -f "$withval/apr-config.in"; then
+      apr_found="unconfigured"
     fi
 
-    dnl if --with-apr is used, then the target prefix/directory must be valid
-    if test "$apr_found" != "yes"; then
+    dnl if --with-apr is used, then the target prefix/directory must be valid and configured
+    if test "$apr_found" = "unconfigured"; then
+      AC_MSG_ERROR([the --with-apr parameter refers to a source directory
+which needs to be built via buildconf/configure/make.])
+    elif test "$apr_found" != "yes"; then
       AC_MSG_ERROR([the --with-apr parameter is incorrect. It must specify an install prefix, a
 build directory, or an apr-config file.])
     fi
Index: ac-helpers/find_apu.m4
===================================================================
--- ac-helpers/find_apu.m4
+++ ac-helpers/find_apu.m4	Fri Jul 26 02:19:18 2002
@@ -62,11 +62,17 @@
     elif test -x "$withval" && $withval --help > /dev/null 2>&1 ; then
        apu_found="yes"
        apu_config="$withval"
+    elif test -f "$withval/apu-config.in"; then
+      apu_found="unconfigured"
     fi
 
     dnl if --with-apr-util is used, then the target prefix/directory must
-    dnl be valid
-    if test "$apu_found" != "yes"; then
+    dnl be valid and configured
+    if test "$apu_found" = "unconfigured"; then
+      AC_MSG_ERROR([
+The directory given to --with-apr-util refers to a source directory
+which needs to be built via buildconf/configure --with-apr/make.])
+    elif test "$apu_found" != "yes"; then
       AC_MSG_ERROR([
 The directory given to --with-apr-util does not specify a prefix for an 
 installed APU, nor an APR-util build directory.])
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org