Re: Delta combiner stress test results

cmpilato@collab.net wrote:

>Karl Fogel <kfogel@newton.ch.collab.net> writes:
>
>
>
>>Branko Čibej <brane@xbc.nu> writes:
>>
>>
>>> * After each set of tests, I recursively compared the working copies
>>> (except the .svn directories). All the working copes were
>>> identical, _except_ that the trunk svn/branch repo combination
>>> corrupted files larget than 100k. I assume there's a latent bug in
>>> the undeltification code on /trunk that shows up when trying to
>>> undeltify files larger than the window size. We didn't notice it
>>> because there are no such files in our repositories. The branch
>>> sbuversion doesn't have this problem.
>>>
>>>
>>Heh. Nice discovery.
>>
>>
>
>I'm confused. Does large_file_integrity() in fs-test.c not do an
>adequate job of testing?
>

No, because on trunk, large files don't get deltified at all. This bug
only showed up when using trunk svn with a repository created by the
branch svn, which _does_ deltify large files.

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org