Re: svn commit: rev 2713 - trunk/subversion/libsvn_repos

kfogel@tigris.org wrote:
>
> Author: kfogel
> Date: 2002-07-25 15:36:17 -0500 (Thu, 25 Jul 2002)
> New Revision: 2713
>
> Modified:
> trunk/subversion/libsvn_repos/repos.c
> Log:
> * subversion/libsvn_repos/repos.c
> (create_hooks): Fix quoting and commenting in pre-commit example.
>
> Modified: trunk/subversion/libsvn_repos/repos.c
> ==============================================================================
> --- trunk/subversion/libsvn_repos/repos.c (original)
> +++ trunk/subversion/libsvn_repos/repos.c Thu Jul 25 15:36:21 2002
> @@ -314,13 +314,13 @@
> "# REPOS=${1}\n"
> "# TXN=${2}\n"
> "#\n"
> - "# Make sure that the log message contains some text.\n"
> + "# ## Make sure that the log message contains some text.\n"
> "# SVNLOOK=/usr/local/bin/svnlook\n"
> "# LOG=`${SVNLOOK} ${REPOS} txn ${TXN} log`\n"
> - "# echo ${LOG} | grep \"[a-zA-Z0-9]\" > /dev/null || exit 1\n"
> + "# echo \"${LOG}\" | grep \"[a-zA-Z0-9]\" > /dev/null || exit 1\n"
> "#\n"
> - "# Check that the author of this commit has the rights to perform the\n"
> - "# commit on the files and directories being modified.\n"
> + "# ## Check that the author of this commit has the rights to perform\n"
> + "# ## the commit on the files and directories being modified.\n"
> "# commit-access-control.pl ${REPOS} ${TXN} commit-access-control.cfg "
> "|| exit 1\n"
> "#\n"

Is this to work around people mis-editing the template files?

I've done this several times myself, such as forgetting to uncomment

# REPOS=${1}
# TXN=${2}

and having the commands fail.

If we're messing these files up, I think a lot of other people will.

Given that they are template files and do not run without somebody
manually moving them, I think we should make the template files be
real scripts with only comments commented out.

Best,
Blair

-- 
Blair Zajac <blair@orcaware.com>
Web and OS performance plots - http://www.orcaware.com/orca/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org