Re: svn commit: rev 2708 - trunk/subversion/clients/cmdline

On Thu, Jul 25, 2002 at 12:50:08PM -0500, sussman@tigris.org wrote:
>...
> +++ trunk/subversion/clients/cmdline/util.c Thu Jul 25 12:50:08 2002
> @@ -256,6 +256,12 @@
> apr_err = apr_filepath_merge (&truenamed_target, "", raw_target,
> APR_FILEPATH_TRUENAME, pool);
>
> + /* ### HACK: apr_filepath_merge("", ".") returns "", which
> + is borken. Sander is looking into fixing this apr bug.
> + Remove this hack when it's fixed: */
> + if (! strcmp (truenamed_target, ""))
> + truenamed_target = ".";

I realize this is just a temporary hack, but strcmp() against the empty
string is just a bit much [for future code]. Instead:

  if (*truenamed_target == '\0')
    truenamed_target = ".";

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org