[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 2684 - trunk/subversion/include trunk/subversion/mod_dav_svn trunk/subversion/clients/cmdline trunk/subversion/libsvn_repos trunk/subversion/libsvn_ra_dav

From: <cmpilato_at_collab.net>
Date: 2002-07-25 16:17:10 CEST

Marcus Comstedt <marcus@mc.pp.se> writes:

> cmpilato@collab.net writes:
>
> > The client, however, wants its output to be consistent with that of
> > `svn update', so it maps like so:
> >
> > A => A
> > D => D
> > R => R
> > M => U
>
> I've been meaning to ask this, but _why_ does it want the output to
> be consistent with that of `svn update'? I think it's rather
> unintuitive. If the log message is
>
> ------------------------------------------------------------------------
> rev 2701: cmpilato | 2002-07-25 04:06:31 +0200 (Thu, 25 Jul 2002) | 3
> lines
> Changed paths:
> U /trunk/tools/cgi/tweak-log.cgi
>
> * tools/cgi/tweak-log.cgi
> (doFetchLog): html-escape the current log that inits the textarea.
>
> ------------------------------------------------------------------------
>
> then this to me looks like you fixed the HTML escaping by updating
> tweak-log.cgi. But this is of course not the case. You fixed it by
> _modifying_ that file. An update doesn't contribute any new
> information to the repository, and thus can't fix anything there.
>
> Why not just let the output be consistent with that of `svn status' at
> the committers end just before the commit instead? That seems more
> logical, since the log is talking about commits and not updates.

I'm only the messenger! :-) Seriously, I personally would *rather* see
the 'M' for modify (same reasons you have), but whoever (Karl?) coded
the original schema wanted otherwise. It's certainly not too late to
change it though -- I mean, the feature has only been working for,
what, a couple of days now? Certainly folks haven't written entire
GUIs around it.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jul 25 16:17:15 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.