[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svnadmin lsrevs grows without bounds

From: <cmpilato_at_collab.net>
Date: 2002-07-25 04:38:11 CEST

Blair Zajac <blair@orcaware.com> writes:

> On my repository using revision 2685, running svnadmin lsrevs uses
> all the available memory on my system (256 Mbytes) before I have
> to kill it.

Don't do that!

Seriously, try this patch to svnadmin/main.c -- does it affect anything?

Index: ./main.c
===================================================================
--- ./main.c
+++ ./main.c Wed Jul 24 21:37:47 2002
@@ -461,6 +461,7 @@
 
     case svnadmin_cmd_lsrevs:
       {
+ apr_pool_t *this_pool = svn_pool_create (pool);
         svn_revnum_t
           lower = SVN_INVALID_REVNUM,
           upper = SVN_INVALID_REVNUM,
@@ -493,7 +494,6 @@
             svn_string_t *datestamp;
             svn_string_t *author;
             svn_string_t *log;
- apr_pool_t *this_pool = svn_pool_create (pool);
             const svn_fs_id_t *root_id;
             svn_string_t *id_str;
             const char *datestamp_native, *author_native, *log_native;
@@ -526,14 +526,15 @@
             printf ("Log (%" APR_SIZE_T_FMT " bytes):\n%s\n",
                     log->len, log_native);
             printf ("==========================================\n");
- INT_ERR (svn_fs_node_id (&root_id, this_root, "", pool));
- id_str = svn_fs_unparse_id (root_id, pool);
+ INT_ERR (svn_fs_node_id (&root_id, this_root, "", this_pool));
+ id_str = svn_fs_unparse_id (root_id, this_pool);
             printf ("/ <%s>\n", id_str->data);
             print_tree (this_root, "", 1, this_pool);
             printf ("\n");
             
- svn_pool_destroy (this_pool);
+ svn_pool_clear (this_pool);
           }
+ svn_pool_destroy (this_pool);
       }
       break;
 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jul 25 04:37:49 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.