[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Quote filename passed to $EDITOR

From: Marcus Comstedt <marcus_at_mc.pp.se>
Date: 2002-07-23 20:47:22 CEST

Karl Fogel <kfogel@newton.ch.collab.net> writes:

> Marcus Comstedt <marcus@mc.pp.se> writes:
> > Why not just cd to wherever the file is, and only pass the filename
> > component to the editor? Since the filename of the tempfile is chosen
> > by svn, it can be chosen so that no quotes at all are necessary,
> > single or double.
> Could do. We'd have to cd out of there afterwards, so the commit
> would proceed from the right place...

Yes, but that shouldn't be a problem. If the user deletes that
directory from inside his editor, we'll just have to bomb out. :)

I think we either need to do it like this, or know about the exact
quoting rules of the shell (the ones on Windows are quite

> Post-Alpha, lest we keep tweaking forever :-). Patch welcome anytime,
> of course.

Maybe I'll make one, but I'd rather see my bugfix patch to
svn_repos_create committed first. (Maybe it already is, the server
seems to be down, so I can't check...)

  // Marcus

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jul 23 20:53:52 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.