[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Quote filename passed to $EDITOR

From: <cmpilato_at_collab.net>
Date: 2002-07-23 20:28:51 CEST

Scott Lamb <slamb@slamb.org> writes:

> On Tue, Jul 23, 2002 at 11:37:56AM -0500, cmpilato@collab.net wrote:
> > > Why not use a replacement for system that doesn't run through a
> > > shell in the first place, fork()/execve().
> >
> > We've been here. Let it die.
>
> Ehh? This strikes me as a much better way to do it. Below is a patch
> that should do this portably, though please don't apply yet - I think I
> will factor the messiness into a new function and use it for other
> invocations (diff?)

I appreciate the patch, especially since it looks pretty darn close to
the one I committed long ago, and like a mirror image of the one I
committed not-quite-so long ago (when I reverted the first one). :-)

Seriously, we have been here before, in threads as long as the Starr
Report, and in the end we decided to stick with system().

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jul 23 20:30:37 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.