Re: [PATCH] Quote filename passed to $EDITOR

> Why not use a replacement for system that doesn't run through a shell in the
> first place, fork()/execve().

We've been here. Let it die.

> > /* Now, run the editor command line. */
> > - cmd = apr_psprintf (pool, "%s %s", editor, tmpfile_native);
> > + cmd = apr_psprintf (pool, "%s \"%s\"", editor, tmpfile_native);
> > sys_err = system (cmd);
> > if (sys_err != 0)
>
> Why not use single quotes? The above just opens a hole for environment
> variable expansion (unintentional or malicious).

Windows doesn't recognize single-quotes as an arg wrapper.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jul 23 18:39:46 2002