Re: [PATCH] Quote filename passed to $EDITOR

On Tue, 2002-07-23 at 01:08, Sander Striker wrote:
> No time to commit right now.
 
> /* Now, run the editor command line. */
> - cmd = apr_psprintf (pool, "%s %s", editor, tmpfile_native);
> + cmd = apr_psprintf (pool, "%s \"%s\"", editor, tmpfile_native);
> sys_err = system (cmd);
> if (sys_err != 0)

Why not use single quotes? The above just opens a hole for environment
variable expansion (unintentional or malicious).

-- 
---------------.                          ,-.   1325 Chesapeake Terrace
Ulrich Drepper  \    ,-------------------'   \  Sunnyvale, CA 94089 USA
Red Hat          `--' drepper at redhat.com   `------------------------