Ok, I did a little testing with the current subversion, and found some
leftovers that need fixing.
First of all, creating a local repository with eightbit characters in
its name using svnadmin didn't work:
| pelix:/% /pike/sw/bin/svnadmin create /pike/data/repos/täst2
|
| subversion/libsvn_repos/repos.c:568
| apr_error: #2, src_err 0 : <No such file or directory>
| creating DAV sandbox dir `/pike/data/repos/täst2/dav'
| pelix:/%
The reason are some apr_dir_make:s that managed to slip though. Patch
to fix at bottom of mail.
Next, I'm getting slightly odd results from svn info:
| pelix:~/svntest/täst2% svn info klädesplagg.txt
| Path: klädesplagg.txt
| Name: klädesplagg.txt
| Url: file:///pike/data/repos/täst2/kl%FF%FFdesplagg.txt
^ ^^^^^^
| Revision: 1
| Node Kind: file
| Schedule: normal
| Last Changed Author: marcus
| Last Changed Rev: 1
| Last Changed Date: 2002-07-20 18:34:38 +0200 (Sat, 20 Jul 2002)
| Text Last Updated: 2002-07-20 18:34:38 +0200 (Sat, 20 Jul 2002)
| Properties Last Updated: 2002-07-20 18:34:21 +0200 (Sat, 20 Jul 2002)
| Checksum: kYl3XSu0PRqc/B8au4fdNA==
|
| pelix:~/svntest/täst2%
Notice the Url. Either quote both "ä":s or none of them. Quoting
only one is just silly. And what's the deal with %FF%FF? Surely that
should be %C3%A4?
// Marcus
Index: subversion/libsvn_repos/repos.c
===================================================================
--- subversion/libsvn_repos/repos.c
+++ subversion/libsvn_repos/repos.c Sat Jul 20 18:22:53 2002
@@ -125,10 +125,8 @@
apr_status_t apr_err;
/* Create the locks directory. */
- apr_err = apr_dir_make (path, APR_OS_DEFAULT, pool);
- if (apr_err)
- return svn_error_createf (apr_err, 0, 0, pool,
- "creating lock dir `%s'", path);
+ SVN_ERR_W (svn_io_dir_make (path, APR_OS_DEFAULT, pool),
+ "creating lock dir");
/* Create the DB lockfile under that directory. */
{
@@ -180,10 +178,8 @@
apr_size_t written;
/* Create the hook directory. */
- apr_err = apr_dir_make (path, APR_OS_DEFAULT, pool);
- if (apr_err)
- return svn_error_createf
- (apr_err, 0, 0, pool, "creating hook directory `%s'", path);
+ SVN_ERR_W (svn_io_dir_make (path, APR_OS_DEFAULT, pool),
+ "creating hook directory");
/*** Write a default template for each standard hook file. */
@@ -563,16 +559,12 @@
SVN_ERR (svn_fs_create_berkeley (repos->fs, repos->db_path));
/* Create the DAV sandbox directory. */
- apr_err = apr_dir_make (repos->dav_path, APR_OS_DEFAULT, pool);
- if (apr_err)
- return svn_error_createf
- (apr_err, 0, 0, pool, "creating DAV sandbox dir `%s'", repos->dav_path);
+ SVN_ERR_W (svn_io_dir_make (repos->dav_path, APR_OS_DEFAULT, pool),
+ "creating DAV sandbox dir");
/* Create the conf directory. */
- apr_err = apr_dir_make (repos->conf_path, APR_OS_DEFAULT, pool);
- if (apr_err)
- return svn_error_createf
- (apr_err, 0, 0, pool, "creating conf dir `%s'", repos->conf_path);
+ SVN_ERR_W (svn_io_dir_make (repos->conf_path, APR_OS_DEFAULT, pool),
+ "creating conf dir");
/* Create the lock directory. */
SVN_ERR (create_locks (repos, repos->lock_path, pool));
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Jul 20 18:44:16 2002