[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 2599 - trunk/tools/cgi

From: Greg Stein <gstein_at_lyra.org>
Date: 2002-07-20 08:42:32 CEST

On Fri, Jul 19, 2002 at 06:50:36PM -0500, kfogel@tigris.org wrote:
> Author: kfogel
> Date: Fri, 19 Jul 2002 18:50:17 -0500
> New Revision: 2599
> Modified:
> trunk/tools/cgi/tweak-log.cgi
> Log:
> * tools/cgi/tweak-log.cgi (main): Subversion log messages are UTF-8,
> so set that in the "Content-type:" header.

Well... that isn't strictly true. The contents of the files might not be
UTF-8, so the "diff" portion will be hosed.

If you want a truly "proper" commit message, then you'd use multipart MIME
messages, with each file going into its own part, and labeled with an
appropriate MIME type and charset. Of course, we haven't defined a charset
property yet, but no biggy.

Going with multipart will surely throw out the notion of "cut out the patch
from the email and apply." But then again: the commit emailer could see that
all portions are in the same charset and skip the multipart thang.

etc etc

Basically: adding/tweaking the content-type is nice, but don't think that is
the proper solution.


Greg Stein, http://www.lyra.org/
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Jul 20 08:40:34 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.