Re: svn commit: rev 2586 - trunk trunk/subversion/libsvn_subr

Karl Fogel wrote:

>Branko Čibej <brane@xbc.nu> writes:
>
>>The purpose of those macros is to hide platform differences. Which,
>>incidentally, is the purpose of APR. That's why you should always use
>>those macros instead of direct comparison, _except_ for APR_SUCCESS,
>>where it doesn't matter because it's guaranteed to be 0 on all
>>platforms.
>>
>>
>
>Or except when the apr function promises to return *precisely*
>APR_EINVAL (to pick a random example) under certain circumstances, and
>the caller needs to look for that circumstance?
>

Well, technically yes, but that's so much more confusing that way.
"Why're you comparing here, but using a macro there? I like the
comparison better, let's throw out the macro ... cool, that still works
... hey, where are all those Win32 bug reports coming from?" You get the
picture.

>I dunno. I'm using the macro test anyway right now in Subversion,
>despite the above.
>

+1

>So the very existence of APR_STATUS_IS_SUCCESS() is controversial, and
>you and I may be fairly said to be on the "against" side, then? :-)
>
>

You may presume to have supposed correctly.

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org