Re: svn commit: rev 2592 - trunk/subversion/tests/clients/cmdline trunk/subversion/tests/clients/cmdline/svntest

sussman@tigris.org wrote:

>-i18n_filename = "b���";
>+i18n_filename = "b���";
>
> i18n_logmsg = "drieëntwintig keer was één keer teveel";
>

It's a good thing that Python was written by C programmers, and thus
taught to cater to their idiosyncracies. I'd still lose the colons at
the end of the lines, though. :-)

> # Set our environment's locale to ISO-8859-1
>- os.putenv('LC_ALL', 'ISO-8859-1')
>+ locale.setlocale(locale.LC_ALL, 'en_US.ISO8859-1')
>

This is still not portable, because locale identifiers differ between
systems. (Windows, for e.g., doesn't use POSIX-compatible locale
identifiers). Damned if I know what to do.

> for arg in varargs: # build the command string
> if windows: command = command + ' "' + str(arg) + '"'
>- else: command = command + " " + `arg`
>+ else: command = command + " " + ' "' + arg + '"'
>
>

Do you notice a certain similarity between two forks in this condition?
Let's lose the condifion, shall we. And I _think_ it should be str(arg).

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org