Re: svn commit: rev 2586 - trunk trunk/subversion/libsvn_subr

Justin Erenkrantz <jerenkrantz@apache.org> writes:
> > I wish. However, currently the functions return EINVAL, not
> > APR_EINVAL. The APR_STATUS_IS_EINVAL macro only tests for the latter,
> > I thought.
>
> On systems where EINVAL is defined (i.e. where the old code
> compiled), APR_EINVAL is just #define'd to EINVAL.
>
> APR is full of neato-tricks like that. -- justin

So on other systems, the APR_STATUS_IS_EINVAL(apr_status) macro can
return true not only when

   apr_status == APR_EINVAL (but not necessarily equal to EINVAL)

...but also when it matches certain other conditions.

In other words, it's fine for apr_xlate_open function to return
APR_EINVAL instead of EINVAL, but if that precise value is to signal a
specific condition, then callers should use a direct equality test
instead of the APR_STATUS_IS_EINVAL() macro. Or so I would think?

-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Jul 20 00:47:56 2002