Re: Removing the --enable-utf8 flag

Karl Fogel wrote:

>Branko Čibej <brane@xbc.nu> writes:
>
>
>>How about reverting to the ascii check only if apr_xlate_open returns
>>APR_ENOTIMPL? In other words, only when there's no iconv available.
>>
>>Huh, but then it could be #ifdef APR_HAS_XLATE.
>>
>>
>
>Sure.
>
>I've committed rev 2586 now, but we can change the conditions under
>which it falls back to check_non_ascii() vs errors. Just wanted
>mainly to get that #ifdef out of there, so we don't have to always ask
>"Did you compile with or without --enable-utf8" anymore. :-)
>
>

O.K.

BTW, once my apr_filepath_encoding patch is in APR, the logic can be:

    encoding = apr_filepath_encoding();
    if (!APR_HAS_XLATE || encoding == APR_FILEPATH_ENCODING_UNKNOWN)
        check_non_ascii(path);
    else if (path_is_from_command_line_arg
             || encoding == APR_FILEPATH_ENCODING_DEFAULT)
        apr_xlate(path);
    else if (encoding == APR_FILEPATH_ENCODING_UTF8)
        just_use(path);
    else
        alarums_and_excursione();

IIRC, APR_HAS_XLATE will always be 0 or 1 in HEAD apr-util, so that you
can use it in runtime conditions.

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org