Karl Fogel <kfogel@newton.ch.collab.net> writes:
> Marcus Comstedt <marcus@mc.pp.se> writes:
> > I'm with Bill here. While basically working, this approach is not as
> > robust as it could be. It's possible to fool it, by using things like
> > ISO-646-whatever for example. (I don't seriously expect anyone to use
> > any ISO-646 variant other than ISO-646-US novadays, that was in the
> > time before ISO-8859, but it still feels a little flakey.) My
> > intention for the --disable-utf8 variants was as a transitory measure
> > while we iron out the problems with the real code. It was never meant
> > to stay.
>
> I think it's a question of how dangerous is it, versus how much will
> it help people who are having iconv problems but need Subversion
> working in the meantime? Anyway, I'll check it in for now, since it's
> basically the same level of robustness as the old code, just without
> the extra compile-time option. We can iron out the robustness at our
> leisure.
The operative word here is "meantime". If you have to set an
envronment variable or something to activate it, then fine. But you
should have to be _aware_ that you're using a workaround when that is
the case. It should not kick in silently. Then you might not even
realize that you have a potential problem.
(And I'm still talking about 1.0 here btw.)
// Marcus
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jul 19 00:14:43 2002