Re: started applying Marcus' patch

Marcus Comstedt wrote:

>=?UTF-8?B?QnJhbmtvIMSMaWJlag==?= <brane@xbc.nu> writes:
>
>
>
>>We can only touch the contents of properties we know about, i.e., the
>>ones starting with "svn:". Our policy has always been that prop valies
>>are binary blobs. We mustn't assume anything about the contents of
>>user props, so we must not touch tnem.
>>
>>
>
>While it must of course be possible to store binary properties, I
>expect that most user properties will actually be text, so it would be
>beneficial to the user to have access to transcoding functionality for
>her own properties as well. As you say, subversion can not a priori
>know what the user wants, to there needs to be a way of telling it.
>
>Explicitly telling subversion which properties are really binary and
>which are really text also allows for commands like proplist -v to
>avoid printing binary data to stdout and messing up the users tty.
>

Uh, that would mean adding property properties. -0.999999.

>>It gets worse. What if the native locale is not some ASCII derivation,
>>but EBCDIC? Then neither the bit test, nor the arithmetic check will
>>help. Use (apr_isascii(foo) && !apr_iscntrl(foo)).
>>
>>
>
>Moot point. If the native locale is EBCDIC, we're gonna crash and
>burn anyway, since lots of code assumes that ASCII can be used without
>transcoding.
>

Really? Which code is that? I don't think there can be very many shuch
places.

>apr_isascii is equivalent to the arithmetic test, by the way.
>

No it's not, it's implemented in terms of the libc's isascii(), which
should work correctly even in EBCDIC locales. APR definitely does
support those.

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org