Greg Stein <gstein@lyra.org> writes:
> On Thu, Jul 18, 2002 at 12:00:52PM -0500, cmpilato@tigris.org wrote:
> >...
> > - const char *full_path;
> > -
> > - if (eb->target)
> > - full_path = svn_path_join (eb->anchor, eb->target, eb->pool);
> > - else
> > - full_path = apr_pstrdup (eb->pool, eb->anchor);
> > -
> > /* Make sure our update target now has the new working revision.
> > Also, if this was an 'svn switch', then rewrite the target's
> > url. All of this tweaking might happen recursively! */
> > SVN_ERR (svn_wc__do_update_cleanup
> > - (full_path,
> > + (svn_path_join_many (eb->pool, eb->anchor, eb->target, NULL),
>
> Heh. Sneaky bastard. :-)
I love that function, and do that kinda thing everywhere now. But
yeah, I'll comment it.
> >...
> > + expected_url = svn_path_join (p_entry->url,
> > + svn_path_uri_encode (base_name, pool),
> > + pool);
>
> This pattern occurs all over the place. How about a utility function?
>
> Name... hmm... svn_url_add_segment() works for me. The doc would state that
> the new segment gets encoded, then joined to the base URL passed. If
> somebody has encoded parts already, then they can just use svn_path_join().
That's a good idea. Will do.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jul 18 20:42:45 2002