[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Check swig version >= 1.3.10

From: Greg Stein <gstein_at_lyra.org>
Date: 2002-07-18 01:48:38 CEST

On Wed, Jul 17, 2002 at 05:46:01PM -0500, Scott Lamb wrote:
> Check for swig version >= 1.3.10 in configure.in, to match the
> requirement stated in subversion/bindings/swig/README.

Heh. The README is wrong. We actually require 1.3.11, and I'd even prefer to
move that up to 1.3.12. I didn't do the latter because I felt that I'd need
the autoconf check before moving to something super-new.

So... with this check in hand, we should be able to require 1.3.12 :-)

> (Is it acceptable to use awk in configure.in? I saw no other uses of it,

Yes, it is fine, although 'sed' is even better. Combine sed to extract the
version string, and then with a code pattern like that in
build/buildcheck.sh, and you can avoid awk altogether.

> but couldn't think of another easy, relatively portable way to extract
> swig's version number. And it would have saved me some frustration to
> not attempt to use swig with an outdated version.)

Sorry 'bout that.

Can you reform the patch a bit for 1.3.12 checking and maybe try using
sed/sh to do the test? When you resubmit, please include a log message. See
the HACKING document for patch submission guides.

Thanks a bunch! I look forward to adding this test.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jul 18 01:46:46 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.