Re: [PATCH] Fix 'svn rm wc/some/dir/'

Philip Martin <philip@codematters.co.uk> writes:

> Well it looks quite simple to fix, but I hesitate to apply this patch
> because a) I don't understand the "Don't remove" comment, b) we're
> near alpha. Does this look correct? Can anyone explain the "Don't
> remove" comment?

Philip, this patch looks correct to me. I think I wrote that comment
long ago, and that it's now obsolete...(/me hears gstein groaning...)

I think the comment refers to a time when the DESTROY_WF flag to
svn_wc_remove_from_revision_control() did something different. (Like,
that flag used to indicate whether or not to leave locally-modified
files within the directory.) But now that routine *always* preserves
locally modified files, regardless of the flag's value. The flag only
toggles between two behaviors:

   * recursively remove .svn areas only
   * recursivel remove both .svn areas and files too.

So your simple change looks safe to me, and looks like the Right
answer. Go ahead and apply it. I'm very happy to see issue #611
fixed for Alpha... it would have been very obvious to newbies.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jul 17 18:07:38 2002