Re: svn commit: rev 2555 - trunk/subversion/include trunk/subversion/libsvn_wc trunk/subversion/libsvn_client trunk/subversion/libsvn_ra_dav

On Tue, Jul 16, 2002 at 10:09:09PM -0500, Karl Fogel wrote:
> cmpilato@collab.net writes:
> > > How do the entries get out of sync? I don't understand how that could
> > > possibly happen. ???
> >
> > handle_resource() in ra_dav's merge.c is using bump_resource() to
> > call the set_wc_prop callback and change the vsn-rsrc-urls. Then,
> > after ra_dav completes entirely, control returns to the client's
> > commit.c, where svn_wc_process_committed() is called to change the
> > actual entries files.
>
> ... So if the client crashes at (say) the beginning of
> svn_wc_process_committed(), then the vsn-rsrc-url will be out-of-sync
> with the entry and the text-base, because process_committed takes care
> of both of those after a commit.
>
> See http://subversion.tigris.org/issues/show_bug.cgi?id=797 for
> details.

Much of that wasn't in there when I looked.

Okay... that clears it up, but I dislike the solution. You're compensating
for a broken loggy system. We've got code to retain integrity, but it is
broken. You've added yet another field to try and keep in sync, but it isn't
necessary if you simply have a proper synchronization system in the logging
code.

For example, the bug states that logging wcprops isn't sufficient because
you could end up running the log which would alter the wcprop, but not the
entry. Hello? Why are we running the log if it isn't complete? That is
suspicious right there.

So now we have a bunch of new RA logic to deal with bugs in the logging
system. But the logging system is still broken, and the RA logic still might
not be enough to compensate for problems in the logging. Bleh.

I'd say: fix the logging by adding wcprops into the mix and making it more
transacted. Then rip out this new RA code.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org