Re: nasty commit bug

On Mon, Jul 15, 2002 at 02:53:23PM -0500, Ben Collins-Sussman wrote:
> cmpilato@collab.net writes:
>
> > Ben Collins-Sussman <sussman@collab.net> writes:
> >
> > > Philip Martin <philip@codematters.co.uk> writes:
> > >
> > > > I would not like to leave the current code in for alpha. I would
> > > > prefer to apply my most recent patch or revert what is there.
> > >
> > > Hmmm, and your parent-child patch applied to r2521 doesn't pass my
> > > regression tests either:
> > >
> > > FAIL: fs-test 22: merging commit
> >
> > This is my fault. Am fixing now.
>
> Well now I'm freakin'... I just reverted the access-baton
> parent/child patch, and this fs-test *passes* again...?!?!

This is precisely why I'm more comfortable with forward motion than reverse.
It sounds like there are some ripple effects that you aren't going to be
able to back out effectively, so we shouldn't even try.

Regardless, Philip should check in any regression tests that he has,
independent of other patches and fixes. That regression test can stay even
if we roll back. Tests can't hurt :-)

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org