[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: nasty commit bug

From: Justin Erenkrantz <jerenkrantz_at_apache.org>
Date: 2002-07-15 20:05:51 CEST

On Mon, Jul 15, 2002 at 12:52:15PM -0500, Ben Collins-Sussman wrote:
> So now I've got a legitimate situation whereby two directories, one an
> immediate child of the other, are both locked. (They were both
> committed.) svn_wc_process_commited comes along into the first
> directory (using an existing access baton), writes and runs a log, and
> then decides it needs to recurse. At the bottom of the function is a
> loop over entry-children. This loop tries to obtain a new access
> baton for the child directory, so that it can recurse; bang, failure,
> because the child dir is already locked.

And, indeed, this is the problem with svn_wc_process_committed()
that we've been discussing all along. That recurse loop in
svn_wc_process_committed() is hard to get into though - it requires
a non-committed copied directory with a modified file. (See the
repro I posted on Saturday.)

I think Philip's latest patches rewrites svn_wc_process_committed()
to handle this. But, I haven't had the chance to review it yet.

BTW, I have no problem reverting access_baton for Alpha. -- justin

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jul 15 20:06:16 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.