[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: nasty commit bug

From: Justin Erenkrantz <jerenkrantz_at_apache.org>
Date: 2002-07-13 20:00:19 CEST

On Sat, Jul 13, 2002 at 06:44:38PM +0100, Philip Martin wrote:
> That gets fixed by r2504? Do you mean that the set of directories
> that get locked is different depending on whether the previous commit
> was interrupted? That sounds like a serious problem that should not
> be hidden by taking an extra lock. The precommit processing should
> always lock the same set of directories.
> Ah, I think I see the real problem. Look at harvest_committables in
> commit_util.c, it's calling lock_dir without checking the return
> value. I think the correct solution is to revert 2504 and wrap
> lock_dir in an SVN_ERR. The when you try the second commit you will
> get an "already locked" error and need to run cleanup before trying
> the commit again.

Not checking for the return from the hashtable was NULL is incorrect.
So, r2504 should stay.

Regardless, my other patch that I'm trying to get reviewed does
change all of the lock_dir's to be wrapped around SVN_ERR. I'm just
waiting for either svn_wc_process_committed() to be fixed or someone
to say that I can commit even with that function broken. -- justin

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Jul 13 20:00:45 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.