[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] Issue #763

From: Justin Erenkrantz <jerenkrantz_at_apache.org>
Date: 2002-07-13 06:31:44 CEST

This patch fixes Issue #763, BUT it doesn't print out the error
message. What would be nice is if the error message were still
printed, but the error wasn't treated as fatal.

Another potential solution would be to have run_post_commit_hook
error a certain code that callers to svn_repos_fs_commit_txn would
know that the commit succeded, but post-commit failed. -- justin

* subversion/libsvn_repos/hooks.c:
  (svn_repos_fs_commit_txn): Do not wrap run_post_commit_hook around
  SVN_ERR, so that post-commit errors are not treated as fatal.

Index: ./subversion/libsvn_repos/hooks.c
--- ./subversion/libsvn_repos/hooks.c
+++ ./subversion/libsvn_repos/hooks.c 2002-07-12 21:12:41.000000000 -0700
@@ -200,7 +200,7 @@
   SVN_ERR (svn_fs_commit_txn (conflict_p, new_rev, txn));
   /* Run post-commit hooks. */
- SVN_ERR (run_post_commit_hook (repos, *new_rev, pool));
+ run_post_commit_hook (repos, *new_rev, pool);
   return SVN_NO_ERROR;

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Jul 13 06:32:11 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.