[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

commit-email.pl directory collapsing broken

From: Blair Zajac <blair_at_orcaware.com>
Date: 2002-07-13 00:03:56 CEST

I noticed that the code in commit-email.pl to collapse the list of
modified directories that should collapse a subject line from

    rev 4 - trunk/apache_configparser trunk/apache_configparser/t


    rev 4 - in trunk/apache_configparser: t lib/Apache

never runs because this code will always evaluate @commonpieces
to 0:

    # collapse the list of changed directories
    my @commonpieces = ();
    my $commondir = '';
    if (($rootchanged == 0) and (scalar @commonpieces > 1))

If this is changed, then there's still another bug that would leave
the common directory in the list of modified directories, like this:

    rev 4 - in trunk/apache_configparser: trunk/apache_configparser t

Do people want this fixed? It'll shorten the email subjects, but
I don't know if anybody wants it the way it currently is, for
parsing purposes, etc.


Blair Zajac <blair@orcaware.com>
Web and OS performance plots - http://www.orcaware.com/orca/
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Jul 13 00:04:25 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.