Re: Problem with svn_wc_process_committed

Karl Fogel <kfogel@newton.ch.collab.net> writes:

> Philip Martin <philip@codematters.co.uk> writes:
> > I don't think it's that bad, it's rather like creating subpools.
>
> Child edit batons, rather, like file_baton while inside the "scope" of
> a dir_baton. (I don't think we do this with pools -- that is, pass
> two pools to a function. Or if we do, it's very rare.)

Compare

svn_error_t *
svn_wc_adm_open (svn_wc_adm_access_t **adm_access,
                 svn_wc_adm_access_t *parent_access,
                 ...);

with the current pool code

apr_pool_t *
svn_pool_create (apr_pool_t *pool);

The pool case could be recast as

svn_error_t *
svn_pool_create (apr_pool_t **sub_pool,
                 apr_pool_t *pool);

Not much difference!

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org