Re: Re: svn commit: rev 2480 - trunk/subversion/clients/cmdline

On Fri, Jul 12, 2002 at 09:02:31AM -0700, Bill Tutt wrote:
>
> > From: Kevin Pilch-Bisson [mailto:kevin@pilch-bisson.net]
> >
> > On Fri, Jul 12, 2002 at 07:57:08AM -0500, Ben Collins-Sussman wrote:
> > >
> > > > + " svn:executable - If present, make the file executable.
> > (Any\n"
> > > > + " attempt to set this property on a directory will be
> > > > ignored.)\n"
> > >
> > > Or you might simply say, "for files only".
> >
> > Well I was trying to be consistent with my upcoming patch for
> > svn_wc_prop_set,
> > which actively ignores the property on directories (as opposed to
> > erroring).
> >
>
> Why would you want to do that? Erroring out on incorrect behavior
> instead of silently handling a user mistake is much more sensible.

It does error in the non-recursive case. In the recursive case it doesn't.
This is because I can see someone doing:

svn pset svn:executable --recursive executable-dir

and expecting all of the files to be made executable. I was originally
thinking of notifying the user that it couldn't be set and continuing, but
that would include adding a bunch of notification framework to the propset
stuff. Instead I figured I'd just go with the principle of least suprise.

-- 
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Kevin Pilch-Bisson                    http://www.pilch-bisson.net
     "Historically speaking, the presences of wheels in Unix
     has never precluded their reinvention." - Larry Wall
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~