Re: mod_dav/mod_dav_svn PROPFINDS.

On Mon, Jul 01, 2002 at 11:49:49AM -0700, Justin Erenkrantz wrote:
>...
> BTW, I *think* it is related to the fact that the dav_svn_do_walk
> function isn't creating a subpool.
>
> I'm specifically looking at subversion/mod_dav_svn.c:1963:
>
> /* fetch this collection's children */
> /* ### shall we worry about filling params->pool? */
> serr = svn_fs_dir_entries(&children, ctx->info.root.root,
> ctx->info.repos_path, params->pool);
>
> If we had svn blame, we could figure out who added the ### comment
> and I believe whomever said that is right.

You may not have svn blame, but you do have CVS:

  http://subversion.tigris.org/source/browse/subversion/subversion/mod_dav_svn/repos.c.diff?r1=1.12&r2=1.13

IOW, I put that comment in on day one, when I wrote the function :-)

>...
> Thanks to Sander who pointed this out to me. I've been trying
> (unsuccessfully) to talk to him wrt to this after he pointed it
> out, so I'll post here in the hopes someone will jump on this.
>
> I'm not sure I have the time to play with this, but I'm willing to
> guess that this is the problem. -- justin

Thanks to all of you for looking into this and fixing it. Kudos!

Very sloppy programming on my part. My only excuse is that mod_dav, its
backend API, and the initial framework for mod_dav_svn were all done before
I (we) really established a solid methodology for subpool usage. mod_dav is
really crappy in terms of subpools (read: it doesn't use them at all).

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org