[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] fixes for apr_vformatter and apr_snprintf

From: Nuutti Kotivuori <naked_at_iki.fi>
Date: 2002-07-11 22:07:54 CEST

Jim Jagielski wrote:
>> After that apr_snprintf returns len-1 if the data just fit and len
>> if it got truncated. Is this what is wanted?
>
> It would appear so... Certainly not being able to tell truncation
> from "it just fit" is non-ideal.

Well yes. But now that we have really decided on the behaviour,
someone should change the documentatoin.

> The "kludge" is the (sp >= beg)...INS_CHAR... stuff right before we
> return cc though, right? Want to make sure that's the code you're
> referring to :)

Yes, the unnecessary flushing at the end.

But, see my other mail - me and Sander basically split the handling of
this issue.

-- Naked

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jul 11 22:08:41 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.