[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 2457 - trunk/www

From: Karl Fogel <kfogel_at_newton.ch.collab.net>
Date: 2002-07-10 20:29:55 CEST

Blair Zajac <blair@orcaware.com> writes:
> The path in this log message and in revisions 512, 906, 933, 1312,
> 1313, 1314, 1467, 1472, 1637, 1638, 1743, 2044, 2371, 2383, 2384
> all have "subversion/" before www/project_faq.html, which doesn't
> actually exist. I think there are other log messages to files
> in www that have the subversion prepended.
>
> We may want to have a log message checker to make sure that the
> paths listed in the log message actually exist.

Heh. No, it exists, but not in the repository -- my working copy is
named "subversion" here, so for example, I have

   /home/kfogel/src/subversion/subversion/libsvn_wc/diff.c

and

   /home/kfogel/src/subversion/www/project_faq.html

and so on. Obviously the name of my top-level working copy should not
be relevant to other users of the repository -- I could have called it
"fish" if I wanted, wouldn't matter. The problem here is a bug in
some elisp code I have that generates log message paths for me. I'll
fix that.

I will correct old repository log messages on a case-by-case basis
Probably not today, but soon.

I don't think there's any need for our log messages script to protect
against this. There are all sorts of errors a person could make
(should it check that the name function actually exists in the named
file, too?), after all.

Thanks for noticing,
-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jul 10 20:40:43 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.